Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cdk tree revamp get label #28143

Draft
wants to merge 1 commit into
base: cdk-tree-revamp
Choose a base branch
from
Draft

Cdk tree revamp get label #28143

wants to merge 1 commit into from

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Nov 16, 2023

No description provided.

@zarend
fix(material/tree): implement getLabel
5dd0e6b 
CdkTreeNode Implements TreeKeyManageItem#getLabel. Fix tree not
responding to typeahead.
@zarend
Copy link
Contributor Author

zarend commented Nov 16, 2023

This is a draft because this is a prototype solution to test that typeahead is working.

Haven't thought through what the API should look like yet. We may need to make it so developers can specify what the label for a given node is through an Input on CdkTreeNode or another method. Using textContent will pick up on things like the toggle button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobobUnicorn BobobUnicorn Awaiting requested review from BobobUnicorn

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn will be requested when the pull request is marked ready for review jelbourn is a code owner

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin will be requested when the pull request is marked ready for review andrewseguin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zarend