fix(material/dialog): dialog actions overflow and are unreachable #28381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before fix screenshot (portrait): Before fix screenshot (landscape): After fix screenshot (portrait): After fix screenshot (landscape): |
essjay05
force-pushed
the
dialog-button-cutoff-fixf
branch
from
3ab943e
to
c6830ff
Compare
essjay05
force-pushed
the
dialog-button-cutoff-fixf
branch
from
c6830ff
to
7f47150
Compare
Fixes a bug in the Angular Material dialog component where buttons/actions are unreachable due to dialog overflowing because of unspecified max-height for the mat-dialog-container parent flexbox. Fixes angular#24785
essjay05
force-pushed
the
dialog-button-cutoff-fixf
branch
from
7f47150
to
8bdb25b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Angular Material dialog component where buttons/actions are unreachable due to dialog overflowing because of unspecified max-height for the mat-dialog-container parent flexbox.
Fixes #24785