Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/autocomplete): panel not visible when opened from multiple triggers #28843

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 8, 2024

Fixes that if one panel is tied to multiple triggers, it ends up becoming invisible because the original trigger resets the state after the next trigger picks it up. These changes avoid the state reset if the trigger has changed.

Fixes #28362.

…le triggers

Fixes that if one panel is tied to multiple triggers, it ends up becoming invisible because the original trigger resets the state after the next trigger picks it up. These changes avoid the state reset if the trigger has changed.

Fixes angular#28362.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 8, 2024
@crisbeto crisbeto removed the request for review from andrewseguin April 14, 2024 09:21
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 14, 2024
@crisbeto crisbeto merged commit 2f17c69 into angular:main Apr 15, 2024
24 of 27 checks passed
crisbeto added a commit that referenced this pull request Apr 15, 2024
…le triggers (#28843)

Fixes that if one panel is tied to multiple triggers, it ends up becoming invisible because the original trigger resets the state after the next trigger picks it up. These changes avoid the state reset if the trigger has changed.

Fixes #28362.

(cherry picked from commit 2f17c69)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
2 participants