Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google-maps): switch to non-deprecated API for clustering and su… #28869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OgiSss
Copy link
Contributor

@OgiSss OgiSss commented Apr 11, 2024

This commit update map marker cluster and support map marker and map advanced marker.

It's related to:
#23695
#24853

@OgiSss OgiSss requested a review from crisbeto as a code owner April 11, 2024 16:54
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 11, 2024
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a change for this in already in #24853. The challenge isn't really the code, but how to roll it out. We'll proceed with #24853 once we've decided on it.

@OgiSss
Copy link
Contributor Author

OgiSss commented Apr 11, 2024

@crisbeto Based on your code i have created a PR to support clusters for both markers and advanced markers. I know that the API between old and new clusters are different but in my opinion it's good idea to update library especially that many people waiting for it. And my code support old markers and new markers. Let me know what do you think about it

@crisbeto
Copy link
Member

I don't think that we would want to support both clustering APIs in a single component since it's too much responsibility for one component and it'll make it harder to delete later. I'll see if I can get #24853 moving again.

@OgiSss
Copy link
Contributor Author

OgiSss commented Apr 13, 2024

@crisbeto I mean I have implemented only one clusterer (the new one) but with support for marker and advanced marker.

@LeLunZ
Copy link

LeLunZ commented Apr 26, 2024

@crisbeto support for the "new" markerclusterer is highly appreciated.
I think the old one is deprecated now for over 2 years.
With the markers beeing deprecated it now makes even less sense to use markerclustererplus.

The new one supports handling for both new and old markers, so I think this PR makes total sense.

I stopped using the angular components years ago, because they didn't support the newest changes with the algorithms and the render function. Thought after upgrading to 17 I can finally use them. But doesn't seem so...

@Siddhu-K
Copy link

Siddhu-K commented May 8, 2024

Any chance this arrives in v18? I recently started using Angular Google Maps and started with the advanced markers due to the deprecation warning. I would like to use the marker clusters.
Should I wait or use the normal markers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants