-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/drag-drop): resolve incompatibility with property minification #28980
Conversation
Fixes that the `showPopover` call was being minified by Closure and preventing the popover from opening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but surprised this is necessary - isn't this a browser API? I wouldn't expect this function name to be minified
I'm a bit surprised as well, but I checked locally that it resolves the issue. My best guess is that typings are outdated somewhere so the compiler didn't know not to minify it. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes that the
showPopover
call was being minified by Closure and preventing the popover from opening.