Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/menu): allow for scroll strategy to be configured #29005

Merged
merged 1 commit into from May 6, 2024
Merged

fix(cdk/menu): allow for scroll strategy to be configured #29005

merged 1 commit into from May 6, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 6, 2024

Adds an injection token that allows users to configure the scroll strategy of a CDK menu.

Fixes #28965.

@crisbeto
fix(cdk/menu): allow for scroll strategy to be configured
e8182c8 
Adds an injection token that allows users to configure the scroll strategy of a CDK menu.

Fixes angular#28965.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 6, 2024
@crisbeto crisbeto requested a review from mmalerba as a code owner May 6, 2024 08:14
andrewseguin
andrewseguin approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name seems weird that "reposition" is tied to "scrollStrategy" but that seems like an old decision. LGTM

@crisbeto crisbeto self-assigned this May 6, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 6, 2024
@crisbeto crisbeto merged commit d2aeb8b into angular:main May 6, 2024
25 of 27 checks passed
crisbeto added a commit that referenced this pull request May 6, 2024
@crisbeto
fix(cdk/menu): allow for scroll strategy to be configured (#29005)
f6864dc 
Adds an injection token that allows users to configure the scroll strategy of a CDK menu.

Fixes #28965.

(cherry picked from commit d2aeb8b)
crisbeto added a commit that referenced this pull request May 6, 2024
@crisbeto
fix(cdk/menu): allow for scroll strategy to be configured (#29005)
23dc148 
Adds an injection token that allows users to configure the scroll strategy of a CDK menu.

Fixes #28965.

(cherry picked from commit d2aeb8b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cdk/menu): allow user to configure scroll strategy on menu triggers
2 participants
@crisbeto @andrewseguin