test(multiple): Update test initializer to provide zoneless #29043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
force-pushed
the
zonelessforalltest
branch
3 times, most recently
from
002a98e
to
8174cf9
Compare
atscott
force-pushed
the
zonelessforalltest
branch
from
8174cf9
to
e36e2c8
Compare
atscott
requested review from
devversion,
josephperrott,
andrewseguin,
mmalerba,
jelbourn and
crisbeto
as code owners
atscott
force-pushed
the
zonelessforalltest
branch
4 times, most recently
from
46988d6
to
c3722a8
Compare
This commit uses the zoneless provier for all tests by default. Tests which failed have either been updated to be compatible or have been opted out. Note that tests which were opted out does not mean the components are incompatible with zoneless, but likely that the tests rely on the zone provider in some way. Opt outs require the private `ZONELESS_ENABLED` token set to `false` in the providers manually because there is a check that will throw an error when both zoneless and zone providers are used. This should likely be fixed in the framework code to make it easier for test suites to do what we're doing here: use zoneless for all tests by default and temporarily use zones for tests that need it until there is time to migrate them.
atscott
force-pushed
the
zonelessforalltest
branch
from
c3722a8
to
73f6c16
Compare
andrewseguin
approved these changes
May 15, 2024
atscott
force-pushed
the
zonelessforalltest
branch
from
ff3de0e
to
8a96385
Compare
andrewseguin
approved these changes
May 16, 2024
atscott
added a commit
to atscott/components
that referenced
this pull request
May 16, 2024
…29043) * test(multiple): Update test initializer to provide zoneless by default This commit uses the zoneless provier for all tests by default. Tests which failed have either been updated to be compatible or have been opted out. Note that tests which were opted out does not mean the components are incompatible with zoneless, but likely that the tests rely on the zone provider in some way. Opt outs require the private `ZONELESS_ENABLED` token set to `false` in the providers manually because there is a check that will throw an error when both zoneless and zone providers are used. This should likely be fixed in the framework code to make it easier for test suites to do what we're doing here: use zoneless for all tests by default and temporarily use zones for tests that need it until there is time to migrate them. * fixup! test(multiple): Update test initializer to provide zoneless by default
andrewseguin
pushed a commit
that referenced
this pull request
May 16, 2024
…29060) * test(multiple): Update test initializer to provide zoneless by default This commit uses the zoneless provier for all tests by default. Tests which failed have either been updated to be compatible or have been opted out. Note that tests which were opted out does not mean the components are incompatible with zoneless, but likely that the tests rely on the zone provider in some way. Opt outs require the private `ZONELESS_ENABLED` token set to `false` in the providers manually because there is a check that will throw an error when both zoneless and zone providers are used. This should likely be fixed in the framework code to make it easier for test suites to do what we're doing here: use zoneless for all tests by default and temporarily use zones for tests that need it until there is time to migrate them. * fixup! test(multiple): Update test initializer to provide zoneless by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the zoneless provier for all tests by default. Tests
which failed have either been updated to be compatible or have been
opted out. Note that tests which were opted out does not mean the
components are incompatible with zoneless, but likely that the tests
rely on the zone provider in some way.
Opt outs require the private
ZONELESS_ENABLEDtoken set tofalsein the providers manuallybecause there is a check that will throw an error when both zoneless and
zone providers are used. This should likely be fixed in the framework
code to make it easier for test suites to do what we're doing here: use
zoneless for all tests by default and temporarily use zones for tests
that need it until there is time to migrate them.