fix(material/chips): simplify repeat chip removal prevention #29048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
G
We have some logic that prevents chip removal if the users is holding down the backspace key. It currently breaks down in the case where a value is pasted into the input via click. These changes simplify our detection by using `KeyboardEvent.repeat` which also resolves the paste issue.
andrewseguin
approved these changes
May 16, 2024
crisbeto
added a commit
that referenced
this pull request
May 16, 2024
We have some logic that prevents chip removal if the users is holding down the backspace key. It currently breaks down in the case where a value is pasted into the input via click. These changes simplify our detection by using `KeyboardEvent.repeat` which also resolves the paste issue. (cherry picked from commit 46bcc21)
crisbeto
added a commit
that referenced
this pull request
May 16, 2024
We have some logic that prevents chip removal if the users is holding down the backspace key. It currently breaks down in the case where a value is pasted into the input via click. These changes simplify our detection by using `KeyboardEvent.repeat` which also resolves the paste issue. (cherry picked from commit 46bcc21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some logic that prevents chip removal if the users is holding down the backspace key. It currently breaks down in the case where a value is pasted into the input via click.
These changes simplify our detection by using
KeyboardEvent.repeatwhich also resolves the paste issue.