fix(material/schematics): estimate missing hues in M3 schematic #29231
+169
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `@material/material-color-utilities` to generate the palettes in the M3 `ng generate` schematic, but it appears that the utilities don't generate all the neutral hues for some colors which leads to transparent dropdowns (see angular#29157). We handle this in our built in palettes by estimating the missing hues based on the hues around them. These changes port the estimation logic to the schematic to ensure that we always generate full themes. Fixes angular#29157.
crisbeto
requested review from
amysorto,
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
commented
Jun 11, 2024
|
|
||
| let newNeutral: Map<number, string> | null = null; | ||
|
|
||
| for (const [hue, {prev, next}] of NEUTRAL_HUES) { |
There was a problem hiding this comment.
The logic here can be simplified, but I wanted to avoid mutating the original map.
amysorto
approved these changes
Jun 11, 2024
crisbeto
added a commit
that referenced
this pull request
Jun 11, 2024
We use `@material/material-color-utilities` to generate the palettes in the M3 `ng generate` schematic, but it appears that the utilities don't generate all the neutral hues for some colors which leads to transparent dropdowns (see #29157). We handle this in our built in palettes by estimating the missing hues based on the hues around them. These changes port the estimation logic to the schematic to ensure that we always generate full themes. Fixes #29157. (cherry picked from commit 3da4323)
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
@material/material-color-utilitiesto generate the palettes in the M3ng generateschematic, but it appears that the utilities don't generate all the neutral hues for some colors which leads to transparent dropdowns (see #29157). We handle this in our built in palettes by estimating the missing hues based on the hues around them.These changes port the estimation logic to the schematic to ensure that we always generate full themes.
Fixes #29157.