fix(bazel): disable angular linker sourcemaps #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the linker on `@angular/material` or packages which contain external sourcemap. The sourcemap will contain multiple sources example. Babel now uses [remapping](https://github.com/ampproject/remapping/) to merge sourcemaps, see: babel/babel#14209. This doesn't support multiple sources which the linker produduces. Previously, Babel failed silently and didn't generate a sourcemap angular/angular#42769 at all. Linker produced sourcemap ```js [ '/packages/web-app-edit/Users/cli-reproductions/monorepo-new/node_modules/@angular/material/fesm2020/card.mjs', '/packages/web-app-edit/Users/src/material/card/card.html', '/packages/web-app-edit/Users/src/material/card/card-header.html', '/packages/web-app-edit/Users/src/material/card/card-title-group.html' ] ``` Will cause the below error during merging ``` Transformation map 0 must have exactly one source file. ``` Related to - angular/angular#42769 - angular/angular#44972 Addresses CI failure - https://app.circleci.com/pipelines/github/angular/angular/42281/workflows/e060088b-5963-43b0-b6fc-b4ddd8855bee/jobs/1116551
|
//cc @JoostK this fixes the issue with esbuild. |
devversion
approved these changes
Feb 4, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the linker on
@angular/materialor packages which contain external sourcemap. The sourcemap will contain multiple sources example.Babel now uses remapping to merge sourcemaps, see: babel/babel#14209. This doesn't support multiple sources which the linker produduces. Previously, Babel failed silently and didn't generate a sourcemap angular/angular#42769 at all.
Linker produced sourcemap
Will cause the below error during merging
Related to
sourceMappingcauses no sourcemaps to be emitted angular#42769Addresses CI failure