Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CSP and recommended security headers to site #914

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jan 29, 2021

  • update cache ages for different types of assets
    • assets 6 months, CDN 1 year
    • js/css that is hashed per build, 1 year
    • webmanifest/ico 7 days, CDN 14 days
    • CLI auto-inlined SVG in root dir 1 year

Relates to angular/angular#37631

Before

Screen Shot 2021-01-29 at 15 57 26
Screen Shot 2021-01-29 at 15 58 38
Screen Shot 2021-01-29 at 16 01 13

After

Screen Shot 2021-01-29 at 15 58 17
Screen Shot 2021-01-29 at 15 58 48
Screen Shot 2021-01-29 at 16 02 43

You can test this out for yourself against https://angularmaterial.dev/ using

@Splaktar
Copy link
Member Author

Splaktar commented Feb 8, 2021

@gkalpak you might be interested in taking a look at this PR for CSP on material.angular.io. I'm planning to put together something similar (not including cache header changes) for AIO soon.

- update cache ages for different types of assets
  - assets 6 months, CDN 1 year
  - js/css that is hashed per build, 1 year
  - webmanifest/ico 7 days, CDN 14 days
  - CLI auto-inlined SVG in root dir 1 year

Relates to angular/angular#37631
@andrewseguin
Copy link
Collaborator

LGTM

@Splaktar Splaktar merged commit ff31a52 into angular:master Feb 18, 2021
@Splaktar Splaktar deleted the csp branch February 18, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants