Conversation
I opened angular/angular#33453 to no longer cause a hard crash for ERROR in Unsupported binary operator: InKeyword, instead interpreting the expression as dynamic. I suspect that will resolve the issue here, as the value of providers does not have to be known at compile time. I will run some tests (likely tomorrow) based on this PR and an Angular build of angular/angular#33453 to verify this. |
I'll merge once we land angular/angular#33453. |
After testing angular/angular#33453 in #476 the compilation error is resolved, but e2e tests are still failing: CI log
|
Thanks @JoostK! I was able to workaround the initial error ( The error we're getting now ( |
@tsvetomir - I am going to help look into this, |
The next failure for the scheduler is indeed i18n related... It is a bug in the ivy runtime - see angular/angular#33594 |
I updated @tsvetomir's sample project with the latest 9.0 rc and am still getting the same issue @StephenFluin. We can patch it on our end for when this release hits. However, this would mean that our clients would need to change how things work on their end as well. Any chance there could be a fix on the framework side before release? |
@alyssamichelle we're looking into this problem. |
Thanks @mgechev. You all are truly amazing. |
@alyssamichelle, @tsvetomir @AndrewKushnir opened a PR with a fix angular/angular#33599. It may not be a part of rc.1, but you can start experimenting with it with a custom build. |
Closing in favour of #525, which extends this PR and also proves that we are now in a good state for these libraries. |
There are some good news and some bad news 馃
The kendo-ui-charts-ngcc project works without any specific Ivy fixes. Seems like Inputs are not inherited when Ivy is enabled聽angular#30080 is gone for good 馃憤
The kendo-ui-grid-ngcc and kendo-ui-scheduler-ngcc projects fail with ERROR in Unsupported binary operator: InKeyword due to an expression in `node_modules/@progress/kendo-angular-dropdowns/dist/fesm5/index.js:
var touch = isWindowAvailable() && 'ontouchstart' in window;
The value of the expression is indirectly provided through DI. I didn't see previous reports for that specific issue.
Ref #386