Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: version 0.47.0 not auto released, typescript incompatibility for angular 15.2.1 #1429

Open
M-a-c-Carter opened this issue Mar 8, 2023 · 1 comment

Comments

@M-a-c-Carter
Copy link

M-a-c-Carter commented Mar 8, 2023

Its not a great practice to point production environments to a master branch or a commit hash of a particular library, for that reason can this team please release v0.47.0?

In the future this package should be considered as a part of angular release planning, its has knock on effects for several libraries and is part of the angular ecosystem, and should at least have a supported version released up to the current version of angular.

I think there has been a mistake or something failed with your auto deploy.
#1423 v0.47.0 never got released on npm as a version, see https://www.npmjs.com/package/tsickle
cc: @h-joo @mprobst @frigus02 @mhausner

Steps to reproduce,
install angular v15.2.1 alongside tsickle, notice 0.46.3 (latest available) is incompatible with the current version of typescript supplied and used by angular (typescript version ~4.9.3)

edit:
"typescript": "4.9.4" should also be changed to "typescript": "~4.9.3" in the package.json
so that it stays in line with angular 15.2.1 (eg it will be as up to date as the latest angular 15.2.1 release)

@frigus02
Copy link
Collaborator

frigus02 commented Mar 8, 2023

Hi there. See also #1421 and https://github.com/angular/tsickle#warning-unsupported. Our general recommendation is: don't use tsickle unless you've specifically chosen to do so. Tsickle is only useful if you're using Closure Compiler and you're likely far better off using a different optimizer/minifier like terser or swc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants