fix: adjust enum transpile to generate var if not const enum #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matches tsc output to correctly support declaration merging
|
Do we know that Closure supports reopening enums in this manner? I don't really understand the rules for how enums work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matches tsc output to correctly support declaration merging.
This would close this issue I opened in reference to supporting declaration merging. It adjusts any enum that is not a
const enumto use thevardeclaration after transpile instead of theconstdeclaration so that declaration merging works correctly. Since declaration merging is not possible with aconst enum, those are left with theconstdeclaration. Updated the appropriate test files to reflect this change.