Skip to content

Commit

Permalink
refactor: remove deprecated engines
Browse files Browse the repository at this point in the history
BREAKING CHANGE:

Deprecated `@nguniversal/aspnetcore-engine`, `@nguniversal/hapi-engine` and `@nguniversal/socket-engine` has been removed in favor of `@nguniversal/common`.

Closes #1232, closes #750 and closes #1454
  • Loading branch information
alan-agius4 committed Mar 7, 2022
1 parent f18c249 commit 2a84fe0
Show file tree
Hide file tree
Showing 73 changed files with 11 additions and 2,869 deletions.
12 changes: 5 additions & 7 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
@@ -1,13 +1,11 @@
/modules/aspnetcore-engine/* @MarkPieszak @dgp1130
/modules/builders @alan-agius4
/modules/common/* @dgp1130 @CaerusKaru
/modules/express-engine/* @dgp1130 @FrozenPandaz
/modules/hapi-engine/* @dgp1130 @CaerusKaru
/modules/common/* @dgp1130 @CaerusKaru @alan-agius4
/modules/express-engine/* @dgp1130 @alan-agius4

# Tooling
/scripts/** @CaerusKaru @dgp1130
/integration/** @CaerusKaru @dgp1130
/tools/** @CaerusKaru @dgp1130
/scripts/** @CaerusKaru @dgp1130 @alan-agius4
/integration/** @CaerusKaru @dgp1130 @alan-agius4
/tools/** @CaerusKaru @dgp1130 @alan-agius4

# Misc
/* @dgp1130
Expand Down
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/Bug.md
Expand Up @@ -21,11 +21,9 @@ issues for `window is not defined` and other hiccups when adopting Angular Unive

<!-- ✍️edit: -->

- [ ] aspnetcore-engine
- [ ] builders
- [ ] common
- [ ] express-engine
- [ ] hapi-engine

### Is this a regression?

Expand Down
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/Feature_Request.md
Expand Up @@ -9,11 +9,9 @@ about: You have an idea that you'd like to be implemented in Angular Universal

<!-- ✍️edit: -->

- [ ] aspnetcore-engine
- [ ] builders
- [ ] common
- [ ] express-engine
- [ ] hapi-engine

### Description

Expand Down
3 changes: 0 additions & 3 deletions .ng-dev/release.ts
Expand Up @@ -5,12 +5,9 @@ import { join } from 'path';
export const release: ReleaseConfig = {
representativeNpmPackage: '@nguniversal/common',
npmPackages: [
{ name: '@nguniversal/aspnetcore-engine' },
{ name: '@nguniversal/builders' },
{ name: '@nguniversal/common' },
{ name: '@nguniversal/express-engine' },
{ name: '@nguniversal/hapi-engine' },
{ name: '@nguniversal/socket-engine' },
],
releaseNotes: {
groupOrder: ['@nguniversal/common', '@nguniversal/builders', '@nguniversal/express-engine'],
Expand Down
5 changes: 0 additions & 5 deletions README.md
Expand Up @@ -37,9 +37,6 @@ The packages from this repo are published as scoped packages under [@nguniversal
- [@nguniversal/common](/modules/common/README.md)
- [@nguniversal/builders](/modules/builders/README.md)
- [@nguniversal/express-engine](/modules/express-engine/README.md)
- [@nguniversal/aspnetcore-engine](/modules/aspnetcore-engine/README.md)
- [@nguniversal/hapi-engine](/modules/hapi-engine/README.md)
- [@nguniversal/socket-engine](/modules/socket-engine)

# Universal "Gotchas"

Expand All @@ -57,9 +54,7 @@ We believe that using the word "universal" is correct when referring to a JavaSc

- [Adam Plumer](https://github.com/CaerusKaru) and [Fabian Wiles](https://github.com/Toxicable) - Current maintainers
- [PatrickJS](https://twitter.com/gdi2290) and [Jeff Whelpley](https://twitter.com/jeffwhelpley) - Founders of the Angular Universal project. (Universal rendering is also called [PatrickJS-ing](https://twitter.com/jeffbcross/status/846512930971516928))
- [Mark Pieszak](https://twitter.com/MarkPieszak) - Contributor and Evangelist, ASP.NET Core Engine
- [Jason Jean](https://github.com/FrozenPandaz) - Express engine and Universal support for CLI
- [Wassim Chegham](https://twitter.com/manekinekko) - Contributor and Evangelist, Hapi engine developer.
- [Angular for the rest of us](https://medium.com/google-developer-experts/angular-universal-for-the-rest-of-us-922ca8bac84)
- [Angular outside the browser](http://slides.com/wassimchegham/angular2-universal#/)
- [Jeff Cross](https://twitter.com/jeffbcross) - Evangelist and performance consultant
Expand Down
27 changes: 0 additions & 27 deletions integration/hapi-engine-ivy/README.md

This file was deleted.

162 changes: 0 additions & 162 deletions integration/hapi-engine-ivy/angular.json

This file was deleted.

4 changes: 0 additions & 4 deletions integration/hapi-engine-ivy/browserslist

This file was deleted.

34 changes: 0 additions & 34 deletions integration/hapi-engine-ivy/e2e/protractor.conf.js

This file was deleted.

70 changes: 0 additions & 70 deletions integration/hapi-engine-ivy/e2e/src/app.e2e-spec.ts

This file was deleted.

0 comments on commit 2a84fe0

Please sign in to comment.