Replace object type with Record<keyof any, unknown> in object-* packages
#550
+42
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masa-Shin
commented
Apr 26, 2023
| export default function entries<T extends Record<keyof any, unknown>>(obj: T): [keyof T, T[keyof T]][]; |
There was a problem hiding this comment.
FYI: keyof any is equivalent to string | number | symbol, which represents the types that can be keys of an object.
Masa-Shin
commented
Apr 26, 2023
| // @ts-expect-error | ||
| extend([]); | ||
| // @ts-expect-error | ||
| extend(() => {}); |
There was a problem hiding this comment.
I moved these tests to the "Not OK" zone because it seems that they are not intended usages of the extend function.
|
If we replace |
|
I see you point, since this is a library it should be able to accept interfaces. So I close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is recommended to use
Record<string, unknown>instead ofobjecttype. Reference.