Chore: docs example for arrow function and tests (fixes eslint#13135)

anikethsaha · Apr 3, 2020 · 6e5b4ec · 6e5b4ec
1 parent 17e2fe4
commit 6e5b4ec
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/docs/rules/no-return-assign.md b/docs/rules/no-return-assign.md
@@ -40,6 +40,10 @@ function doSomething() {
 function doSomething() {
     return foo += 2;
 }
+
+const foo = (a,b) => a = b
+
+const bar = (a, b, c) => (a = b, c == b)
 ```
 
 Examples of **correct** code for the default `"except-parens"` option:
@@ -58,6 +62,10 @@ function doSomething() {
 function doSomething() {
     return (foo = bar + 2);
 }
+
+const foo = (a, b) => (a = b)
+
+const bar = (a, b, c) => ((a = b), c == b)
 ```
 
 ### always

diff --git a/tests/lib/rules/no-return-assign.js b/tests/lib/rules/no-return-assign.js
@@ -52,7 +52,8 @@ ruleTester.run("no-return-assign", rule, {
         {
             code: "() => (result = a * b)",
             options: ["except-parens"]
-        }
+        },
+        "const foo = (a,b,c) => ((a = b), c)"
     ],
     invalid: [
         {
@@ -79,7 +80,12 @@ ruleTester.run("no-return-assign", rule, {
         },
         {
             code: "() => result = a * b",
-            errors: [{ messageId: "arrowAssignment", type: "ArrowFunctionExpression" }]
+            errors: [
+                {
+                    messageId: "arrowAssignment",
+                    type: "ArrowFunctionExpression"
+                }
+            ]
         },
         {
             code: "function x() { return result = a * b; };",
@@ -95,6 +101,10 @@ ruleTester.run("no-return-assign", rule, {
             code: "function x() { return result || (result = a * b); };",
             options: ["always"],
             errors: [{ messageId: "returnAssignment", type: "ReturnStatement" }]
+        },
+        {
+            code: '"const foo = (a,b,c) => (a = b, c)"',
+            errors: [{ messageId: "returnAssignment", type: "ReturnStatement" }]
         }
     ]
 });