Fix eval #491
Open
Fix eval #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiteracyFanatic
force-pushed
the
fix-eval
branch
from
e3fc550
to
9c2bf7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 18.91% 18.64% -0.27%
==========================================
Files 107 107
Lines 4208 4140 -68
==========================================
- Hits 796 772 -24
+ Misses 3412 3368 -44
Continue to review full report at Codecov.
|
LiteracyFanatic
force-pushed
the
fix-eval
branch
from
9c2bf7d
to
6c3fe34
Compare
|
A fallback (with a warning) if it fails would be good. |
vn-ki
reviewed
Aug 25, 2020
|
|
||
| def eval_in_node(js: str): | ||
| def eval_in_node(js: str, sandbox: str = "{}"): |
There was a problem hiding this comment.
Shouldn't this be transparent? We can't assume the next developer (who's going to use eval_in_node for implementing a provider) to know how to construct a sandbox string.
|
We should use https://github.com/amol-/dukpy instead, that would also remove our dependency for nodejs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #486. It will almost definitely have broken other places that use
eval_in_node. I'll add commits fixing those later. I'll also write some guidelines on how to use the js evaluation since it's gotten a bit more complicated than before. Hopefully the end result will be more robust and rely less on parsing scripts as strings.