chore: cleanups to allow List-based input of collection path #15784
+164
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-allison
changed the title
david-allison
force-pushed
the
3114-select-storage-location
branch
4 times, most recently
from
0e96bdf
to
55347e6
Compare
david-allison
changed the title
david-allison
force-pushed
the
3114-select-storage-location
branch
from
55347e6
to
16bb08d
Compare
If a call to super is requested, `null` may be returned In this case, `super` would be called This is useful if you would optionally want to inherit from a class (say `EditTextPreference`), but also allow conditionally return a different fragment
I know `getExternalFilesDir(null)!!` can throw, I'm unsure if the array can throw, but it's best to be safe here
This exists as we want a dialog to show either a List or an EditText, and both the framework classes require inheritance For Issue 3114
david-allison
force-pushed
the
3114-select-storage-location
branch
from
16bb08d
to
3b43ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onDisplayPreferenceDialog: If a call to super is requested,nullmay be returned In this case,superwould be calledThis is useful if you would optionally want to inherit from a class (say
EditTextPreference), but also allow conditionally return a different fragmentListPreferenceif the user is onplayEditTextPreferenceif the user is onfullOne refactoring to
CollectonManagerA new trait which allows a list preference to optionally be displayed when a preference is clicked