Fix #15553: Start of Next Day Not Working

[powy-e]

Purpose / Description

After finishing all cards for a day, changing Start of Next Day to the past and trying to access that same deck would result in a message saying that all cards were finished for the day.
Previously, this issue would require restarting anki.

Fixes

• Fixes [BUG]: Start of Next Day Not Working #15553

Approach

I fixed this issue by selecting another deck and reselecting the deck again, prompting a reload of said deck.

How Has This Been Tested?

By following @briankrznarich steps to reproduce the bug, on a physical device (Samsung A33 5G, Android 14)

• With a rollover of 8pm, finish all cards for the day.
• On the Deck Summary screen, at 2pm, with all cards finished, set the rollover to noon. (i.e. "the past")
• On the Deck Screen, newly due cards appear (~500 for me)
• Tap the deck to start reviewing

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[welcome]

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

[david-allison]

I'd expect this change to be made in opExecuted.

We want to update state when a state change is detected, rather than when the next user action is detected

In addition: decks.select(0) seems to be incorrect on first glance. 0 is not a deckId

---

I'd appreciate a unit test here, as the bug reproduction steps are complex

[github-actions]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

[github-actions]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically