Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated AndroidPermanentlyRevokedPermissionsDialog to AlertDialog #16266

Merged
merged 1 commit into from
May 19, 2024
Merged

Migrated AndroidPermanentlyRevokedPermissionsDialog to AlertDialog #16266

merged 1 commit into from
May 19, 2024

Conversation

neeldoshii
Copy link
Contributor

@neeldoshii neeldoshii commented Apr 24, 2024 •
edited

Fixes

Screenshots

Before (Material Dialog) After (Alert Dialog
screenshot screenshot

@neeldoshii

This comment was marked as outdated.

Sign in to view
@neeldoshii neeldoshii mentioned this pull request Apr 24, 2024
Merged
5 tasks
@neeldoshii neeldoshii marked this pull request as ready for review April 26, 2024 11:43
@BrayanDSO
Copy link
Member

uses the extension functions of 057ea62

Why don't you cherry-pick it? Right now, this doesn' pass CI, isn't buidable and can't be reviewed

@BrayanDSO BrayanDSO marked this pull request as draft April 26, 2024 17:33
@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Apr 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 10, 2024
@neeldoshii
Copy link
Contributor Author

On break for next 3 weeks. Commenting so "Stale" tag will be removed.

@github-actions github-actions bot removed the Stale label May 11, 2024
@david-allison david-allison added the Keep Open avoids the stale bot label May 14, 2024
@neeldoshii neeldoshii force-pushed the revoke-permission-to-alertdialog branch from 52e88dc to 21e9c75 Compare May 18, 2024 10:01
@neeldoshii neeldoshii marked this pull request as ready for review May 18, 2024 10:01
@neeldoshii neeldoshii force-pushed the revoke-permission-to-alertdialog branch from 73247ed to 7d5922b Compare May 18, 2024 10:19
lukstbit
lukstbit approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Keep Open avoids the stale bot labels May 19, 2024
david-allison
david-allison approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 19, 2024
@david-allison david-allison added this pull request to the merge queue May 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2024
@david-allison david-allison added this pull request to the merge queue May 19, 2024
Merged via the queue into ankidroid:main with commit 62eff67 May 19, 2024
8 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 19, 2024
@github-actions github-actions bot added this to the 2.19 release milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukstbit lukstbit lukstbit approved these changes

@david-allison david-allison david-allison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19 release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neeldoshii @BrayanDSO @lukstbit @david-allison