migrate gradle to build-logic / composite build module to share build logic between modules

[AbdelrahmanEsam]

Purpose / Description

Describe the problem or feature and motivation

Fixes

• Fixes #

Approach

How does this change address the problem?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

This hasn't been discussed and there's a lot here

What's the advantage?

This needs the PR description filled in

[AbdelrahmanEsam]

@david-allison hi david .... I will discuss this with you at discord

[david-allison]

Thanks! Can you post the reply here so people looking into the history can understand

[david-allison]

I don't see a message in Discord and I'm getting loads of notifications from this

It would be useful to discuss first, as it's currently a "close & don't merge" unless there's reasoning given

[lukstbit]

Ok with the idea not with the implementation(too much extracted, too fragmented).
This also really needs a series of smaller precise commits not just one mega commit.

[AbdelrahmanEsam]

@david-allison hi david hope you are doing well .... can you help me figureing out why emulator tests fails ?

[david-allison]

I want to go back to lukstbit and my unanswered comments first.

There's little point of getting this passing CI if we don't know whether we're going to merge it or not.

I'll rerun CI

[AbdelrahmanEsam]

well I am using a build-logic module for building the app but why ?
well this have good results like
1- you are using regular kotlin code for build your app so it's so much easier to any kotlin dev to do it .
2- now your build is composable so you can share the same gradle plugin to more than one module instead of rewrite the same logic in more than one module and when you alter it you are altering it with all of your modules so this is good for archtiecture .

you can read more about composite build here
https://docs.gradle.org/current/userguide/composite_builds.html

[david-allison]

Comment stands

Ok with the idea not with the implementation(too much extracted, too fragmented).
This also really needs a series of smaller precise commits not just one mega commit.

[github-actions]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically