Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(card-browser): extract 'launchOptions' #16291

Merged
merged 1 commit into from
May 22, 2024

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Apr 28, 2024

Final extraction from #14843 before testing

Please don't merge this until we cut for 2.19

@david-allison david-allison added Needs Review Blocked by dependency Currently blocked by some other dependent / related change labels Apr 28, 2024
@david-allison david-allison removed Blocked by dependency Currently blocked by some other dependent / related change Has Conflicts labels May 14, 2024
Final extraction from 14843 before testing
Copy link
Contributor

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 22, 2024
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 22, 2024
@BrayanDSO BrayanDSO added this pull request to the merge queue May 22, 2024
Merged via the queue into ankidroid:main with commit 4f474d1 May 22, 2024
8 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 22, 2024
@github-actions github-actions bot added this to the 2.19 release milestone May 22, 2024
@david-allison david-allison deleted the card-browser-final branch May 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants