remove chromeos release files

[RobozinhoD]

Purpose / Description

Describe the problem or feature and motivation

Fixes

• Fixes marketing-titles.txt and chromeos release are no longer used and should be removed #16340

Approach

I removed the files specified in the issue

How Has This Been Tested?

I can't test it

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Message to maintainers, this PR contains strings changes.

1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings

[kpdyer16]

I definitely need a second opinion on this review, but I think the code pruning could go a bit deeper, and there's also a breaking change.

The key here is that ankidroid-titles.txt is generated/updated by update.ts. So even if we delete the ankidroidtitles, it may regenerate next time localizations are updated.

I would also investigate to see if any of those marketdescription files are also exclusively a chromeos thing, and if so, remove those and the code that generates them.

[kpdyer16]

This breaks the localization update flow, e.g. here

Anki-Android/tools/localization/src/update.ts

Line 150 in 9a81b50

fs.appendFileSync(TITLE_FILE, "\n" + language + ": " + translatedTitle);

With this change, it would try to write to a directory, throwing an error. I think the right move would be to remove this line, and any uses of TITLE_FILE in update.ts. There isn't any other file that imports this, so I think it should be relatively safe to remove.

[mikehardy]

Thanks @RobozinhoD !

It is possible the market description could go as well but let's do one at a time :-), I haven't looked in to that one at all but I did look at ankidroid titles

This does look like the full removal of ankidroid titles (thanks for the review @kpdyer16)

There is no great way to test this (there are some non-great ways that involve making your own copy of ankidroid crowdin and stuff, but I can't really recommend)

So note to maintainers (probably future me): DO NOT MERGE THIS until you are ready to do an i18n sync, then look very very carefully at the output to make sure things look correct (the CI workflow log, the PR generated, etc)

[mikehardy]

does seem like it needs a rebase - I believe that will be the case every single time an i18n sync is run prior to this merging though, so ignore it for now.

second note to maintainers: when this is ready to merge, rebase it right then, and then merge it, prior to doing any i18n sync work to verify the functionality here

[mikehardy]

this is ready (and has been ready, really) so I followed my own maintainer note with a rebase to fix the conflict (we are just deleting a file entirely, so not a complicated thing...) and will merge

[github-actions]

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings