Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit test for Reviewer.kt. #16391

Merged
merged 1 commit into from
May 21, 2024

Conversation

Haz3-jolt
Copy link
Contributor

Purpose / Description

Added Unit test to function with @NeedsTest.

Fixes

  • Created test for AddNote() to address "Starting animation from swipe is inverse to the finishing one".

Approach

  • Unit test completed.

How Has This Been Tested?

  • Ran the Unit test multiple times, and ensured it is passing.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In future, please ping if you feel things are forgotten about

AnkiDroid/src/test/java/com/ichi2/anki/ReviewerTest.kt Outdated Show resolved Hide resolved
AnkiDroid/src/test/java/com/ichi2/anki/ReviewerTest.kt Outdated Show resolved Hide resolved
@Haz3-jolt
Copy link
Contributor Author

Haz3-jolt commented May 20, 2024

Thanks! In future, please ping if you feel things are forgotten about

Forgot about the PR myself lol! No worries at all

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y'know, none of these are blocking, let's go!

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label May 20, 2024
@Haz3-jolt
Copy link
Contributor Author

Y'know, none of these are blocking, let's go!

I did make the changes btw

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!

Copy link
Contributor

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
A request for future tests: there's no need to add comments with Arrange/Act/Assert. These could be useful for someone just starting to read tests but later becomes verbose. Adding an empty line between the logical groups is perfectly fine.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 21, 2024
@lukstbit lukstbit added this pull request to the merge queue May 21, 2024
Merged via the queue into ankidroid:main with commit 887f51b May 21, 2024
6 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 21, 2024
@github-actions github-actions bot added this to the 2.19 release milestone May 21, 2024
@Haz3-jolt Haz3-jolt deleted the my-feature-branch-1 branch May 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants