-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Unit test for Reviewer.kt. #16391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! In future, please ping if you feel things are forgotten about
Forgot about the PR myself lol! No worries at all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y'know, none of these are blocking, let's go!
0e0402e
to
0acaddb
Compare
I did make the changes btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A request for future tests: there's no need to add comments with Arrange/Act/Assert. These could be useful for someone just starting to read tests but later becomes verbose. Adding an empty line between the logical groups is perfectly fine.
Purpose / Description
Added Unit test to function with @NeedsTest.
Fixes
Approach
How Has This Been Tested?
Checklist