Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle android app links in previewer #16409

Merged
merged 4 commits into from
May 19, 2024
Merged

Conversation

MorenoTropical
Copy link
Contributor

Purpose / Description

Readd a feature

Fixes

Approach

Implements the feature

How Has This Been Tested?

Tapped the link provided in the issue on the previewer

Learning (optional, can help others)

Nothing

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label May 16, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also handle intent://, as the Reviewer does

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label May 16, 2024
@mikehardy mikehardy added this to the 2.18.1 release milestone May 16, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, cheers!

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs error handling - I handled a crash here a few years ago due to issues here

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 19, 2024
@lukstbit lukstbit added this pull request to the merge queue May 19, 2024
Merged via the queue into ankidroid:main with commit 9a49a9f May 19, 2024
8 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 19, 2024
@github-actions github-actions bot modified the milestones: 2.18.1 release, 2.19 release May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Front card template android-app:// links not working in Preview screen since 2.18.0
5 participants