Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: currentCard not initialized #16417

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

BrayanDSO
Copy link
Member

Fixes

https://forums.ankiweb.net/t/what-does-this-error-mean/44915

Approach

Initialize the variable instead of depending of lateinit

How Has This Been Tested?

Opened the templatePreviewer with Don't keep activities on + the current unit tests

Learning (optional, can help others)

Don't trust any lateinit

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • [X ] You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 17, 2024
Copy link
Contributor

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
Based on the linked forum discussion I'm tagging this to be cherry picked.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) Queued for Cherry Pick to Stable Branch and removed Needs Second Approval Has one approval, one more approval to merge labels May 19, 2024
@lukstbit lukstbit added this pull request to the merge queue May 19, 2024
Merged via the queue into ankidroid:main with commit 59fbe88 May 19, 2024
11 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone May 19, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants