Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial gnome module #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apprehensions
Copy link

No description provided.

@apprehensions apprehensions marked this pull request as draft February 26, 2024 07:33
@annacrombie
Copy link
Owner

Sorry for the delayed response on this, it looks really good! I don't have any gnome experience at all so if you think that this is useful in its current state then I will go ahead and merge it. I probably won't advertise that muon has gnome module support until more things are fleshed out but I think this is a great start!

Part of the delay has been that I have been working on a refactor of the core parser/interpreter of muon that should make the execution of script modules a lot more robust and performant.

@apprehensions
Copy link
Author

i cannot express in words how cool and awesome you are for taking the time to maintain muon and do all these things, it's almost like as if you love doing this

@annacrombie
Copy link
Owner

Hmm, this refactor is taking longer than I thought. I'd like to go ahead merge this though so I can use it to test stuff on. I feel like it is a good base for the rest of the gnome module and might be useful for other people who want to reference it when writing script modules. If you mark the gnome test as failing and the PR ready for review I'll get it in and then fix issues as they come.

@apprehensions apprehensions marked this pull request as ready for review March 21, 2024 15:47
@apprehensions
Copy link
Author

The gnome module is incomplete, and lacks GObject. The rest of the important functions needed to setup rudimentary simple Gnome projects (Without GObject, GTK can be built) is supplied by the gnome module.

@annacrombie
Copy link
Owner

ima merge this soon

@apprehensions
Copy link
Author

apprehensions commented Apr 17, 2024

latest commit untested and only rebased (and formatted) (and installed glib deps for CI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants