Murisi/shared masp2 #848
Closed
Murisi/shared masp2 #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/shared_masp2
branch
from
340a703
to
dcbc058
Compare
tzemanovic
reviewed
Dec 5, 2022
| @@ -18,6 +18,52 @@ use masp_primitives::transaction::{ | |||
| }; | |||
| use masp_proofs::sapling::SaplingVerificationContext; | |||
|
|
|||
| use std::collections::hash_map::Entry; | |||
There was a problem hiding this comment.
if think we could move the additions into a sub-module and re-export here what's needed
|
|
||
| async fn query_epoch(&self) -> Epoch; | ||
|
|
||
| fn local_tx_prover(&self) -> LocalTxProver; |
There was a problem hiding this comment.
Is LocalTxProver specific to the consumer? Something that would differ from what is being done on desktop/CLI?
Comment on lines
+267
to
+275
| async fn query_conversion( | ||
| &self, | ||
| asset_type: AssetType, | ||
| ) -> Option<( | ||
| Address, | ||
| Epoch, | ||
| masp_primitives::transaction::components::Amount, | ||
| MerklePath<Node>, | ||
| )>; |
There was a problem hiding this comment.
Also here, does this mean that we should define this in a web/WASM specific way?
async fn query_conversion(
&self,
asset_type: AssetType,
) -> Option<(
Address,
Epoch,
masp_primitives::transaction::components::Amount,
MerklePath<Node>,
)>;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored the platform specific components out of
ShieldedContextand then movedShieldedContextinto thesharedcrate. Essentially addressing: #302 .