Shared sdk integration Branch (do not close) #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of BlockResult keys.
…ctive components.
murisi
force-pushed
the
mariari/shared-sdk-integration
branch
from
80625a4
to
fd98fda
Compare
|
pls spawn devnet [anoma-devnet-0.13.0-zondax,10,heliaxdev@1be9883,ON] |
|
pls spawn devnet [anoma-devnet-0.12.0,10,heliaxdev@1be9883,ON] |
1 similar comment
|
pls spawn devnet [anoma-devnet-0.12.0,10,heliaxdev@1be9883,ON] |
|
Is this still relevant? |
|
closing in favor of #1350 |
juped
changed the title
juped
added a commit
that referenced
this pull request
May 17, 2023
* mariari/shared-sdk-integration: Replaced tendermint branch with commit hash. Now use WalletUtils as a backup for when alias/password parameters are not supplied. Removed new_password_prompt since it is equivalent to read_and_confirm_pwd. refactor: read_and_confirm_pwd and new_password_prompt moved to the client Fixed clippy compilation errors. feat: poll without tokio Removed default-features flag from tendermint-rpc. [ci] wasm checksums update Fixed dependencies for WASM builds. [ci] wasm checksums update Fixed the import errors in the E2E tests. The SDK now uses a local trait called Client that is just a copy of Tendermints. deps: update to masp crate with wasm-compatible libsecp256k1 Disabled http-client in tendermint-rpc dependency. Disabled http-client in tendermint-rpc dependency. changed tendermint-rpc dep to one from memasdeligeorgakis/tendermint-rs Add a namada-sdk feature UMove the useage of tendermint_rpc to the crate level Turn off the default features of tokio Remove an explicit reference to `save` as it is in apps not shared Remove all warnings not associated with a lack of a doc string Removing panics in singing and promoting them to the Result type Using the given result types in client, and progate usage in shared Convert over the boolean functions to being of Result Converted all panics except for the boolean functions Turn `expect` into encoding failures Abstract out common query_storage_value pattern Ran the formatter Abstract out rpc::known_adddress calls, converted more panics Converted over more uses of panic, also abstracted known validator Turning panics in tx.rs into returning results Alias namada::ledger::tx to just tx Remove extra imports from refactoring Made ShieldedUtils trait smaller. Reduced usage of generic parameters. Moved more tx.rs functions into shared. Moved more tx.rs functions into shared. Moved more tx.rs functions into shared. Extended WalletUtils to allow prompting for aliases. Started moving functions from tx.rs and rpc.rs. Parameterized tx functions by storage location. Moved functions from rpc.rs into the shared crate. Generalized functions to depend on Client instead of HttpClient. Moved CLI arguments into the shared crate. Added some documentation. Moved Wallet into the shared crate and parameterized it by its interactive components. Factored out saving and loading code from Wallet. Now pass down Client as a parameter in ShieldedContext. Reduced dependency of rpc.rs on Context. Removed Context dependency from submit_transfer. Replaced Context parameters with Wallets. Removed the WASM file reading from tx.rs. Pass native token into tx function through args instead of Context. Removed some unnecessary parameters. Started parameterizing code by client. Added conversion functions for arguments. Started to parameterize CLI arguments. Fixed help for show-transfers subcommand. Started adding documentation. Moved query_tx_deltas into shared crate. Now attach events to decryptable transactions. Corrected the parsing of BlockResult keys. Moved ShieldedContext into shared crate. Started factoring platform dependent code out of ShieldedContext. Moved gen_shielded_transfer into ShieldedContext. Reaggregated transaction creation code.
juped
added a commit
that referenced
this pull request
May 17, 2023
* mariari/shared-sdk-integration: Replaced tendermint branch with commit hash. Now use WalletUtils as a backup for when alias/password parameters are not supplied. Removed new_password_prompt since it is equivalent to read_and_confirm_pwd. refactor: read_and_confirm_pwd and new_password_prompt moved to the client Fixed clippy compilation errors. feat: poll without tokio Removed default-features flag from tendermint-rpc. [ci] wasm checksums update Fixed dependencies for WASM builds. [ci] wasm checksums update Fixed the import errors in the E2E tests. The SDK now uses a local trait called Client that is just a copy of Tendermints. deps: update to masp crate with wasm-compatible libsecp256k1 Disabled http-client in tendermint-rpc dependency. Disabled http-client in tendermint-rpc dependency. changed tendermint-rpc dep to one from memasdeligeorgakis/tendermint-rs Add a namada-sdk feature UMove the useage of tendermint_rpc to the crate level Turn off the default features of tokio Remove an explicit reference to `save` as it is in apps not shared Remove all warnings not associated with a lack of a doc string Removing panics in singing and promoting them to the Result type Using the given result types in client, and progate usage in shared Convert over the boolean functions to being of Result Converted all panics except for the boolean functions Turn `expect` into encoding failures Abstract out common query_storage_value pattern Ran the formatter Abstract out rpc::known_adddress calls, converted more panics Converted over more uses of panic, also abstracted known validator Turning panics in tx.rs into returning results Alias namada::ledger::tx to just tx Remove extra imports from refactoring Made ShieldedUtils trait smaller. Reduced usage of generic parameters. Moved more tx.rs functions into shared. Moved more tx.rs functions into shared. Moved more tx.rs functions into shared. Extended WalletUtils to allow prompting for aliases. Started moving functions from tx.rs and rpc.rs. Parameterized tx functions by storage location. Moved functions from rpc.rs into the shared crate. Generalized functions to depend on Client instead of HttpClient. Moved CLI arguments into the shared crate. Added some documentation. Moved Wallet into the shared crate and parameterized it by its interactive components. Factored out saving and loading code from Wallet. Now pass down Client as a parameter in ShieldedContext. Reduced dependency of rpc.rs on Context. Removed Context dependency from submit_transfer. Replaced Context parameters with Wallets. Removed the WASM file reading from tx.rs. Pass native token into tx function through args instead of Context. Removed some unnecessary parameters. Started parameterizing code by client. Added conversion functions for arguments. Started to parameterize CLI arguments. Fixed help for show-transfers subcommand. Started adding documentation. Moved query_tx_deltas into shared crate. Now attach events to decryptable transactions. Corrected the parsing of BlockResult keys. Moved ShieldedContext into shared crate. Started factoring platform dependent code out of ShieldedContext. Moved gen_shielded_transfer into ShieldedContext. Reaggregated transaction creation code.
juped
added a commit
that referenced
this pull request
May 18, 2023
This was omitted in 0.16.0's changelog.
Closed
tzemanovic
added a commit
that referenced
this pull request
May 21, 2023
* mateusz/shared-sdk-integration-wip: changelog: add #1238 wasm: update checksums feat: point to the masp_proofs with correct multicore feature flag feat: disable multicore ff by default, make ShieldedUtils trait async format: rustfmt for incorrect sdk-wallet-force commits changelog: add #925, update changelog: add #889 DoS checks in fee specs for fee unshielding ci: remove clippy-abcipp check Adjusts block proposer address in fee specs Improves unshielding tx verification in fee specs Updates tendermint link in fee specs Improves gas accounting in specs Updates check table in fee specs Misc updates to fee specs Fixes wal in fee specs Adds protocol transactions to fee specs Adds governance proposals to fee specs Fixes unshielding in fee specs Enforces tx type order in fee specs Refactors sections of fee specs Adds unshielding to fee specs Updates fee specs Adds fee specs
This was referenced May 21, 2023
brentstone
pushed a commit
that referenced
this pull request
Jun 1, 2023
This was omitted in 0.16.0's changelog.
brentstone
added a commit
that referenced
this pull request
Jun 1, 2023
* brent/cubic-slashing: WIP changes from Manu and logging fixing `find_slashes_in_range` pos sm test: ease load on the CI changelog: #892 fixup!: don't call `process_slashes` within `advance_epoch` clean up logging fix clippy remove test code until slash pool transfers are solved rip slash pool get_slashed_amount: inclusive on infraction epoch add cli to sdk impl for tx unjail make find_slashes_in_ranges inclusive on end epoch withdraw: fix bounds for collecting slashes for an unbond aesthetic cleaning revert bound cleaning for readability refactor slash lookup fixup! add cubic_slash_window_length to bounds (maybe still needs change) remove unused cubic slash function refactor epoch offsets with params methods store total bond sums of each validator for efficient computation pos/lib.rs: WIP fix things inside of `bonds_and_unbonds` fix PoS client query related functions fix `bond_amount` state machine test: add slashing basic nested map test slashing: unit and e2e tests Makefile and Cargo.toml cubic and general slashing algorithms and transactions format: rustfmt for incorrect sdk-wallet-force commits changelog: add #925, update ci: remove clippy-abcipp check changelog: add #889 DoS checks in fee specs for fee unshielding Adjusts block proposer address in fee specs Improves unshielding tx verification in fee specs Updates tendermint link in fee specs Improves gas accounting in specs Updates check table in fee specs Misc updates to fee specs Fixes wal in fee specs Adds protocol transactions to fee specs Adds governance proposals to fee specs Fixes unshielding in fee specs Enforces tx type order in fee specs Refactors sections of fee specs Adds unshielding to fee specs Updates fee specs Adds fee specs
brentstone
pushed a commit
that referenced
this pull request
Jun 1, 2023
This was omitted in 0.16.0's changelog.
brentstone
added a commit
that referenced
this pull request
Jun 1, 2023
* brent/cubic-slashing: fix wasm tx tests WIP changes from Manu and logging fixing `find_slashes_in_range` pos sm test: ease load on the CI changelog: #892 fixup!: don't call `process_slashes` within `advance_epoch` clean up logging fix clippy remove test code until slash pool transfers are solved rip slash pool get_slashed_amount: inclusive on infraction epoch add cli to sdk impl for tx unjail make find_slashes_in_ranges inclusive on end epoch withdraw: fix bounds for collecting slashes for an unbond aesthetic cleaning revert bound cleaning for readability refactor slash lookup fixup! add cubic_slash_window_length to bounds (maybe still needs change) remove unused cubic slash function refactor epoch offsets with params methods store total bond sums of each validator for efficient computation pos/lib.rs: WIP fix things inside of `bonds_and_unbonds` fix PoS client query related functions fix `bond_amount` state machine test: add slashing basic nested map test slashing: unit and e2e tests Makefile and Cargo.toml cubic and general slashing algorithms and transactions format: rustfmt for incorrect sdk-wallet-force commits changelog: add #925, update ci: remove clippy-abcipp check changelog: add #889 DoS checks in fee specs for fee unshielding Adjusts block proposer address in fee specs Improves unshielding tx verification in fee specs Updates tendermint link in fee specs Improves gas accounting in specs Updates check table in fee specs Misc updates to fee specs Fixes wal in fee specs Adds protocol transactions to fee specs Adds governance proposals to fee specs Fixes unshielding in fee specs Enforces tx type order in fee specs Refactors sections of fee specs Adds unshielding to fee specs Updates fee specs Adds fee specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration branch for #921