Make the database root user require a password. #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `MYSQL_ALLOW_EMPTY_PASSWORD=yes` it will use the default `MYSQL_ROOT_PASSWORD=`, resulting in the root user having an EMPTY PASSWORD per default, too easily resulting in anonaddy#272.
crazy-max
reviewed
May 4, 2024
| @@ -11,7 +11,6 @@ services: | |||
| volumes: | |||
| - "./db:/var/lib/mysql" | |||
| environment: | |||
| - "MYSQL_ALLOW_EMPTY_PASSWORD=yes" | |||
There was a problem hiding this comment.
This is just an example and not necessary to make it require. Please see my comment in related issue #272 (comment)
There was a problem hiding this comment.
"It is not necessary to make this secure on default." - Why, what's the hurt in this?
There was a problem hiding this comment.
As stipulated in #272 (comment) I don't mind if we set MARIADB_RANDOM_ROOT_PASSWORD=yes instead.
Also one of these is required anyway, you can't just remove this env: https://hub.docker.com/_/mariadb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
MYSQL_ALLOW_EMPTY_PASSWORD=yesand no
MYSQL_ROOT_PASSWORDset,it will use the default
MYSQL_ROOT_PASSWORD=,resulting in the root user having an EMPTY PASSWORD per default,
too easily resulting in #272.