lib: improve AbortController creation duration

PR-URL: nodejs#45525 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
anonrig · Jan 3, 2023 · 911ea20 · 911ea20
1 parent 2098d7a
commit 911ea20
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js
@@ -318,6 +318,8 @@ function validateAbortController(obj) {
 }
 
 class AbortController {
+  #signal;
+
   constructor() {
     this[kSignal] = createAbortSignal();
   }
@@ -327,15 +329,16 @@ class AbortController {
    */
   get signal() {
     validateAbortController(this);
-    return this[kSignal];
+    this.#signal ??= createAbortSignal();
+    return this.#signal;
   }
 
   /**
    * @param {any} reason
    */
   abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
     validateAbortController(this);
-    abortSignal(this[kSignal], reason);
+    abortSignal(this.#signal ??= createAbortSignal(), reason);
   }
 
   [customInspectSymbol](depth, options) {