Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Get the default branch from env vars also allow to overwrite as parameter #230

Merged
merged 2 commits into from Jan 2, 2023

Conversation

sbe-arg
Copy link
Collaborator

@sbe-arg sbe-arg commented Dec 25, 2022

Hotfix

@sbe-arg sbe-arg requested a review from sammcj December 25, 2022 07:01
entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sbe-arg sbe-arg changed the title Get the baster branch from env vars also allow to overwrite as parameter Fix: Get the master branch from env vars also allow to overwrite as parameter Dec 25, 2022
@sbe-arg sbe-arg changed the title Fix: Get the master branch from env vars also allow to overwrite as parameter Fix: Get the default branch from env vars also allow to overwrite as parameter Dec 25, 2022
@sbe-arg
Copy link
Collaborator Author

sbe-arg commented Jan 2, 2023

I'm back lets merge this

@sbe-arg sbe-arg merged commit 172098f into master Jan 2, 2023
@sbe-arg sbe-arg deleted the hotfix/default_branch_logs branch January 2, 2023 23:34
@martinjlowm
Copy link

This broke our CI with:

The DEFAULT_BRANCH should be autodetected when tag-action runs on on PRs else must be defined, See: https://github.com/anothrNick/github-tag-action/pull/230, since is not defined we find it natively
fatal: ref refs/remotes/origin/HEAD is not a symbolic ref
default_branch=

Apparently, the GITHUB_BASE_REF fallback is empty as well.

@JP-Dhabolt
Copy link
Contributor

JP-Dhabolt commented Jan 5, 2023

@sbe-arg @sammcj
This change was not backwards compatible and broke our CI as well.

The DEFAULT_BRANCH should be autodetected when tag-action runs on on PRs else must be defined, See: https://github.com/anothrNick/github-tag-action/pull/230, since is not defined we find it natively
fatal: ref refs/remotes/origin/HEAD is not a symbolic ref
default_branch=
Error: DEFAULT_BRANCH must not be null, something has gone wrong.

Edit: I commented here, as this is where the error message linked to, but I actually think it is #235 that broke things, as #235 introduced the exit 1.

@Drew-Kimberly
Copy link

+1 to the above. This change broke our CI as well w/ the same error

@PrakharSrivastav
Copy link

+1 . Broke the existing CI

@afranzoy
Copy link

afranzoy commented Jan 5, 2023

+1. Broke our CI pipenline with the error: "DEFAULT_BRANCH must not be null, something has gone wrong."

@sonyavera
Copy link

+1

1 similar comment
@artem-tomyuk
Copy link

+1

@sammcj
Copy link
Collaborator

sammcj commented Jan 5, 2023

This project badly needs tests, especially if folks are going to run the action from main.

@sbe-arg please revert

@sammcj
Copy link
Collaborator

sammcj commented Jan 5, 2023

If anyone here is/was affected by this breaking change, has development (or test automation) skills and is interested to helping to maintain this project - please let me or @sbe-arg know on the following issue - #238

This project isn't ours, we've just been added as contributors because it went unmaintained for some time. The project doesn't have reasonable test coverage (see #184), which is in part why we suggest people don't run it from main/master unless you're happy to be testing cutting edge changes.

We're only two folks, in the same time zone so it's currently very much a best effort as we both work full time and have social lives etc...

See #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants