Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node 18 and set bash -e for error catching #258

Merged
merged 3 commits into from May 10, 2023
Merged

Update to node 18 and set bash -e for error catching #258

merged 3 commits into from May 10, 2023

Conversation

sbe-arg
Copy link
Collaborator

@sbe-arg sbe-arg commented May 6, 2023 •
edited

Self explanatory.

Bumps node to v18 lts and sets bash to -e for better error captures

@sbe-arg sbe-arg requested a review from sammcj May 6, 2023 08:47
@sbe-arg sbe-arg changed the title Update to node 18 and set bash +e for error catching Update to node 18 and set bash -e for error catching May 6, 2023
@sbe-arg sbe-arg mentioned this pull request May 6, 2023
Closed
@sbe-arg
Copy link
Collaborator Author

sbe-arg commented May 8, 2023

@sammcj

sammcj
sammcj approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@sammcj sammcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that took me a while, notification overload!

LGTM

@sbe-arg
Copy link
Collaborator Author

sbe-arg commented May 10, 2023

Ill merge this, this week

@sbe-arg sbe-arg merged commit 72f3a54 into master May 10, 2023
4 checks passed
@sbe-arg sbe-arg deleted the node18-set-e branch May 10, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammcj sammcj sammcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbe-arg @sammcj