Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running 1.63 in a fresh repo without tags it fails to validate existing tags #261

Merged
merged 1 commit into from May 12, 2023
Merged

When running 1.63 in a fresh repo without tags it fails to validate existing tags #261

merged 1 commit into from May 12, 2023

Conversation

sbe-arg
Copy link
Collaborator

@sbe-arg sbe-arg commented May 11, 2023 •
edited

Testing ran here nothing else relevant was found
https://github.com/sbe-arg/dummy-releases/actions

@sammcj it's not urgent

@sbe-arg sbe-arg requested a review from sammcj May 11, 2023 04:48
@sbe-arg sbe-arg mentioned this pull request May 11, 2023
Closed
sammcj
sammcj approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@sammcj sammcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a comment as to why the OR true is needed (or a link to the relevant issue perhaps), but otherwise seems fine.

@sbe-arg
Copy link
Collaborator Author

sbe-arg commented May 11, 2023

Ill add a comment block explaining each || true

@sbe-arg sbe-arg merged commit c360518 into master May 12, 2023
8 checks passed
@sbe-arg sbe-arg deleted the set-e-fixes branch May 12, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammcj sammcj sammcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbe-arg @sammcj