Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove -qs from pre release tag case #267

Merged
merged 1 commit into from May 15, 2023
Merged

remove -qs from pre release tag case #267

merged 1 commit into from May 15, 2023

Conversation

sbe-arg
Copy link
Collaborator

@sbe-arg sbe-arg commented May 15, 2023 •
edited

since we use || true there is no need for -s and -q results in an always null pretag var

this breaks some flows where we bump an existing pretag

@sbe-arg sbe-arg mentioned this pull request May 15, 2023
Closed
@sbe-arg sbe-arg requested a review from sammcj May 15, 2023 02:06
sammcj
sammcj approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@sammcj sammcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agree, this seems fine

@sbe-arg sbe-arg merged commit 94666f1 into master May 15, 2023
12 checks passed
@sbe-arg sbe-arg deleted the fix/pre-releases branch May 15, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammcj sammcj sammcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbe-arg @sammcj