Fix pipefail error caused by piping output to head #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing. Ill run a test just to cuadriple confirm. Thanks a million for this. |
|
Looks good, can you address the shellcheck double quoting so we can merge this? |
Yup, just implemented the suggested fixes from spellcheck so it workflows should pass now 👍 |
sbe-arg
approved these changes
May 21, 2023
|
Please see #271 XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #269
Summary of changes
Fixes a pipefail error caused by piping output to the head function. Instead of using pipes, output is now saved into vars which are passed between functions.
Breaking Changes
Do any of the included changes break current behaviour or configuration?
NO
How changes have been tested
Tested by creating a repo with 998 tags and then running the workflow against it.
List any unknowns
-N/A