Disable action validation with tasks by default #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
changed the title
tadeboro
approved these changes
Feb 19, 2021
I have some other work in progress to be included in the same patch release, but I wanted to avoid big patches as they are more likely to include bugs. This sorts the most common issue encountered by v5 early adopters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should address mentioned bug by introducing a small risk of not catching some invalid module calls for roles that do not have playbooks inside the same repository.
All users that have at least one playbook that imports the role, will still be able to detect these errors as ansible-playbook --syntax-check finds them.
We plan to add a feature that would create fake temporary playbooks for roles found inside a repository, ones that would help us identify missing or misspelled modules.
Fixes: #1354