Skip to content

Commit

Permalink
Disable action validations with tasks by default
Browse files Browse the repository at this point in the history
Fixes: #1354
  • Loading branch information
ssbarnea committed Feb 18, 2021
1 parent 3cad55f commit a6a8402
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .ansible-lint
Expand Up @@ -48,3 +48,7 @@ extra_vars:
line1
line2
complex_variable: ":{;\t$()"

# Uncomment to enforce action validation with tasks, usually is not
# needed as Ansible syntax check also coverts it.
# skip_action_validation: false
1 change: 1 addition & 0 deletions src/ansiblelint/config.py
Expand Up @@ -54,6 +54,7 @@
loop_var_prefix=None,
offline=False,
extra_vars=None,
skip_action_validation=True,
)

# Used to store detected tag deprecations
Expand Down
5 changes: 4 additions & 1 deletion src/ansiblelint/utils.py
Expand Up @@ -60,6 +60,7 @@
LoadingFailureRule,
RuntimeErrorRule,
)
from ansiblelint.config import options
from ansiblelint.constants import FileType
from ansiblelint.errors import MatchError
from ansiblelint.file_utils import Lintable, get_yaml_files
Expand Down Expand Up @@ -516,7 +517,9 @@ def normalize_task_v2(task: Dict[str, Any]) -> Dict[str, Any]:
sanitized_task = _sanitize_task(task)
mod_arg_parser = ModuleArgsParser(sanitized_task)
try:
action, arguments, result['delegate_to'] = mod_arg_parser.parse()
action, arguments, result['delegate_to'] = mod_arg_parser.parse(
skip_action_validation=options.skip_action_validation
)
except AnsibleParserError as e:
raise MatchError(
rule=AnsibleParserErrorRule(),
Expand Down

0 comments on commit a6a8402

Please sign in to comment.