Add optional rule that check for no-same-owner #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
0/x
branch
2 times, most recently
from
d693b2c
to
250886e
Compare
ssbarnea
force-pushed
the
0/x
branch
2 times, most recently
from
8a494c5
to
12a4f9c
Compare
Add a new rule that identifies use of the same owner when transferring files between hosts as a violation. This rule is disabled by default and user needs to manually activate it inside the config as it is needed only for very particular use-cases. Reference: https://zuul-ci.org/docs/zuul-jobs/policy.html#preservation-of-owner-between-executor-and-remote
greg-hellings
approved these changes
Mar 10, 2021
We already do, because the .ansible-lint file from the root of the repository is included inside the docs at config, section. Basically we documented it by only mentioning it there, is sneaky but practical, look at https://ansible-lint.readthedocs.io/en/latest/configuring.html |
This was referenced Mar 11, 2021
Merged
This was referenced Mar 12, 2021
ziegenberg
added a commit
to ziegenberg/ansible-lint
that referenced
this pull request
May 3, 2022
With PR ansible#1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags with `-v` should also list the opt-in rules. Fixes: ansible#2068 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/ansible-lint
that referenced
this pull request
May 3, 2022
With PR ansible#1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags with `-v` should also list the opt-in rules. Fixes: ansible#2068 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/ansible-lint
that referenced
this pull request
May 3, 2022
With PR ansible#1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags with `-v` should also list the opt-in rules. Fixes: ansible#2068 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/ansible-lint
that referenced
this pull request
May 4, 2022
With PR ansible#1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags should also list the opt-in rules. Fixes: ansible#2068 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/ansible-lint
that referenced
this pull request
May 4, 2022
With PR ansible#1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags should also list the opt-in rules. Fixes: ansible#2068 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ssbarnea
added a commit
that referenced
this pull request
May 4, 2022
* Include opt-in rules when listing tags and rules With PR #1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags should also list the opt-in rules. Fixes: #2068 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at> * gracefully handle invalid format options with listing rules Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at> * put arguments -L and -T into a mutually exclusive group We either print a list of rules or a list of tags, but never both at the same time. So it makes no sense to allow giving both arguments at the same time. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at> * always provide a long form of cli arguments Having short cli arguments for often used options is nice to have when using the command in an interactive shell. For writing scripts it would be better to have long forms of arguments as it increases the readebility. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at> * Update tox.yml Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new rule that identifies use of the same owner when transferring files between hosts as a violation.
This rule is disabled by default and user needs to manually activate it inside the config as it is needed only for very particular use-cases.
Adding this rule to the linter should make it much easier for others to reuse it if they seem fit and ease upgrades of the linter, as the custom rule no longer needs to be ported to newer version of the linter.
Reference: https://zuul-ci.org/docs/zuul-jobs/policy.html#preservation-of-owner-between-executor-and-remote