Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include opt-in rules when verbosely listing tags and rules #2098

Closed
wants to merge 0 commits into from

Conversation

ziegenberg
Copy link
Contributor

With PR #1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags with -v should
also list the opt-in rules.

Fixes: #2068

@ziegenberg ziegenberg force-pushed the fix-2068 branch 2 times, most recently from 19bdb0e to fad94d4 Compare May 3, 2022 13:16
@ziegenberg ziegenberg marked this pull request as ready for review May 3, 2022 16:39
@ziegenberg ziegenberg requested review from a team as code owners May 3, 2022 16:39
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to fix listing of opt-in rules and tags only for verbose mode. Can you please remove all the logic around making this dependent on verbosity?

@ziegenberg
Copy link
Contributor Author

Changed as requested. I also adapted the docs and removed the -v from the command for listing tags.

@ssbarnea
Copy link
Member

ssbarnea commented May 4, 2022

Please rebase so we can include it, sorry for the conflicts.

@ziegenberg
Copy link
Contributor Author

As PR #2099 is based on and included this PR, this is now closed after rebasing. How do we get this commit into the next release notes?

@ziegenberg ziegenberg deleted the fix-2068 branch May 4, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line options to list tags and rules does not include opt-in rules.
2 participants