Remove include missing file rule #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As current versions of Ansible do correctly detect missing imports and raise load-failure errors, we no longer need our own rule for it.
|
This is only suppored by ansible-core 2.12, which is in development. I'm not sure whether it's a good idea to remove the rule already now. |
Closed
felixfontein
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As current versions of Ansible do correctly detect missing imports and raise load-failure errors, we no longer need our own rule for it.
This also fixes CI devel jobs which recently started to fail due to changes made to devel branch. Please note that removal of this rule does not mean the linter would not detect missing files, in fact it already does via ansible loader. Before this change missing files caused two different errors for each missing file on 2.9-2.11 and failed to pass tests on 2.12 (devel).