Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Check tests #1592

Closed
wants to merge 1 commit into from
Closed

[WIP] Check tests #1592

wants to merge 1 commit into from

Conversation

felixfontein
Copy link
Contributor

No description provided.

@felixfontein
Copy link
Contributor Author

The failing tests were caused by ansible/ansible#74809. ansible-playbook --syntax-check now fails when it cannot find the included file in TestIncludeMissingFileRule.test_include_file_missing, and ansible-lint never runs the IncludeMissingFileRule rule.

@felixfontein
Copy link
Contributor Author

ansible-core's behavior before: succeeds with

[DEPRECATION WARNING]: Included file '/path/to/some_file.yml' not found, however since this include is not explicitly marked as 'static: yes', we will try and include it dynamically later. In the future, this will be an error unless 'static: no' is used on the include task. If you do not want missing includes to be considered dynamic, use 'static: yes' on the include or set the global ansible.cfg options to make all includes static for tasks and/or handlers. This feature will be removed from ansible-base in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

ansible-core's behavior now: fails with

ERROR! Unable to retrieve file contents
Could not find or access '/path/to/some_file.yml' on the Ansible Controller.
If you are using a module and expect the file to exist on the remote, see the remote_src option

@felixfontein
Copy link
Contributor Author

Closing in favor of #1599.

@felixfontein felixfontein deleted the tests branch June 2, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant