no-changed-when: improve testing and documentation

[konstruktoid]

• adds tests to the no-changed-when rule
• improve documentation

Signed-off-by: Thomas Sjögren konstruktoid@users.noreply.github.com
Fixes: #1681

[ssbarnea]

The code looks really good but I am afraid that the problem is #1681 - I asked for extra feedback from others on community channel.

[konstruktoid]

Updated, but the description probably need better wording.

[ssbarnea]

Looks ok to me but let's wait for @acozine to review the wording for the docs.

[konstruktoid]

My bad, didn't mean to close. The mobile app played tricks on me.

[acozine]

Looks good overall. I put some suggestions for wording - accept the ones you like and ignore the ones you don't. I tried to think about the error message itself, whether there's a way to keep it short but make it more user-focused, but I haven't come up with any ideas yet.

[MarkusTeufelberger]

The existing when case is wrong by the way (the presence of when: true does not influence the idempotence of a task result), but that likely needs a separate PR to be fixed. It could need a test case though, if you're already writing tests.

[konstruktoid]

The existing when case is wrong by the way (the presence of when: true does not influence the idempotence of a task result), but that likely needs a separate PR to be fixed. It could need a test case though, if you're already writing tests.

Yeah, but I believe that is out-of-scope for this PR.