Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-changed-when: improve testing and documentation #1706

Merged
merged 7 commits into from Sep 7, 2021
Merged

no-changed-when: improve testing and documentation #1706

merged 7 commits into from Sep 7, 2021

Commits on Aug 25, 2021

  1. add tests and assume we handle the command output when we use registe… 

    …r or args

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
    @konstruktoid
    konstruktoid committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    8fbdb6f View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. commands should still be handled even if register is used 

    Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
    @konstruktoid
    konstruktoid committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    0392349 View commit details
    Browse the repository at this point in the history

  2. update test task names and args: should pass 

    Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
    @konstruktoid
    konstruktoid committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    38ddf6e View commit details
    Browse the repository at this point in the history

  3. expand the rule description 

    Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
    @konstruktoid
    konstruktoid committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    79d5d63 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Update src/ansiblelint/rules/CommandHasChangesCheckRule.py 

    Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
    @konstruktoid @acozine
    konstruktoid and acozine committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    afbbe46 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. update description wording 

    Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
    @konstruktoid
    konstruktoid committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    7c5b368 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Merge branch 'main' into ISSUE1681

    @ssbarnea
    ssbarnea committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    1474f8d View commit details
    Browse the repository at this point in the history