This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Specify SaveOptions in server capabilities #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmorawetz, this might not be the correct solution as it is breaking a lot of end-to-end tests with our supported VS Code Ansible extension. Please look into it. |
|
Sorry for the late reply, but I am quite busy right now. I will take a look at it. Hopefully soon. |
|
@dmorawetz I am closing this because work on ansible/vscode-ansible#1134 will require us to close all existing pull requests. Still, in few days you should be able to reopen it on the new location. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Pure-D/serve-d#320, this PR adds SaveOptions to ther server capabilities, to make some editors send a
textDocument/didSaveevent.I confirmed the fix with helix version 23.10.
includeTextis set tofalseas I think the text is not used, but I am not familiar with this projects code.Relevant docs: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_didSave
Related issue on Helix side: helix-editor/helix#3957