Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show severity in Github Workflow command message #1055

Merged
merged 4 commits into from Oct 5, 2020
Merged

Show severity in Github Workflow command message #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5dceb5
Show severity in Github Workflow command message
JiriSko Sep 14, 2020
6a11108
Change GHA Workflow output
JiriSko Sep 14, 2020
8f3d41f
Fix GHA Workflow test
JiriSko Sep 16, 2020
6e4847c
Fix docs comment
JiriSko Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/ansiblelint/formatters/__init__.py
View file
Open in desktop
Expand Up @@ -107,9 +107,9 @@ class AnnotationsFormatter(BaseFormatter):
in a form of GitHub Checks API annotations that appear rendered in pull-
request files view.

::debug file={name},line={line},col={col}::{message}
::warning file={name},line={line},col={col}::{message}
::error file={name},line={line},col={col}::{message}
::debug file={name},line={line},col={col},severity={severity}::{message}
::warning file={name},line={line},col={col},severity={severity}::{message}
::error file={name},line={line},col={col},severity={severity}::{message}

Supported levels: debug, warning, error
"""
Expand All @@ -123,9 +123,10 @@ def format(self, match: "MatchError", colored: bool = False) -> str:
file_path = self._format_path(match.filename or "")
line_num = match.linenumber
rule_id = match.rule.id
severity = match.rule.severity
violation_details = match.message
return (
f"::{level} file={file_path},line={line_num}"
f"::{level} file={file_path},line={line_num},severity={severity}"
f"::[E{rule_id}] {violation_details}"
)

Expand Down
2 changes: 1 addition & 1 deletion test/TestCliRolePaths.py
View file
Open in desktop
Expand Up @@ -128,7 +128,7 @@ def test_run_playbook_github(result, env):
result_gh = run_ansible_lint(role_path, cwd=cwd, env=env)

expected = (
'::error file=examples/example.yml,line=47::[E101] '
'::error file=examples/example.yml,line=47,severity=MEDIUM::[E101] '
'Deprecated always_run'
)
assert (expected in result_gh.stdout) is result