-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add User/Team tab to AWX projects #2237
Conversation
eb3c295
to
826e3b1
Compare
QA'ed locally, works as expected Project Teams and Users tab
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Can we get some component tests added please?
5d1e486
to
446c552
Compare
446c552
to
b5f16fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm recommending a few URL changes to match a discussion @vidyanambiar and I had about making these sorts of URLs more consistent
90862e7
to
c8140d1
Compare
@keithjgrant Fixed! Thanks for pointing it out. |
a7ef54b
to
75f8dd3
Compare
It looks like the Projects test(s) need to be updated to check for the new tab labels |
e11dc0f
to
46d34e3
Compare
46d34e3
to
f5881c5
Compare
b1b8ae2
to
3b3b8ec
Compare
3b3b8ec
to
7a827c7
Compare
No description provided.