Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifier tests - edit and delete #2316

Merged
merged 23 commits into from
May 21, 2024
Merged

Notifier tests - edit and delete #2316

merged 23 commits into from
May 21, 2024

Conversation

MilanPospisil
Copy link
Contributor

Adding edit and delete notifier tests.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels May 15, 2024
@MilanPospisil MilanPospisil force-pushed the milan_controller_notifier_tests3 branch 3 times, most recently from 615abc8 to af0d44b Compare May 20, 2024 08:54
@MilanPospisil MilanPospisil marked this pull request as ready for review May 20, 2024 09:08
@MilanPospisil MilanPospisil marked this pull request as draft May 20, 2024 09:08
@MilanPospisil MilanPospisil force-pushed the milan_controller_notifier_tests3 branch from 9da82c1 to 0f95853 Compare May 20, 2024 11:59
@MilanPospisil MilanPospisil force-pushed the milan_controller_notifier_tests3 branch from 0f95853 to 69fcd40 Compare May 21, 2024 09:41
@MilanPospisil MilanPospisil marked this pull request as ready for review May 21, 2024 12:39
@jerabekjiri
Copy link
Contributor

@MilanPospisil not sure if you know, but we have custom cypress command cy.getByDataCy that can save you some typing time and replaces cy.get('[data-cy="..."]')

jerabekjiri
jerabekjiri approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@jerabekjiri jerabekjiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@prat98 prat98 self-requested a review May 21, 2024 14:40
prat98
prat98 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@prat98 prat98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@MilanPospisil MilanPospisil reopened this May 21, 2024
@MilanPospisil MilanPospisil merged commit aea64cf into main May 21, 2024
34 checks passed
@MilanPospisil MilanPospisil deleted the milan_controller_notifier_tests3 branch May 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerabekjiri jerabekjiri jerabekjiri approved these changes

@prat98 prat98 prat98 approved these changes

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MilanPospisil @jerabekjiri @prat98