Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add roles tab tests for users #2320

Merged
merged 3 commits into from
Jun 4, 2024
Merged

add roles tab tests for users #2320

merged 3 commits into from
Jun 4, 2024

Conversation

appuk
Copy link
Member

@appuk appuk commented May 15, 2024

@github-actions github-actions bot added EDA Label to indicate changes relevant to EDA E2E End-to-end testing labels May 15, 2024
@appuk appuk force-pushed the add-roles-tab branch 3 times, most recently from 3478b4c to 658c13e Compare May 15, 2024 18:02
@vishsanghishetty vishsanghishetty self-requested a review May 16, 2024 17:24
@appuk appuk marked this pull request as draft May 20, 2024 15:19
@appuk appuk marked this pull request as ready for review May 28, 2024 22:20
vishsanghishetty
vishsanghishetty reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@vishsanghishetty vishsanghishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run the tests successfully all the tests except users-role-tab hitting 400s

cypress/e2e/eda/Users/users-roles-tab.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/eda/Users/users-roles-tab.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/eda/Users/users-roles-tab.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/eda/Users/users-roles-tab.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/eda/Users/users-roles-tab.cy.ts Show resolved Hide resolved
cypress/e2e/eda/Users/users-roles-tab.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/eda/Access-Management/teams-roles-tab.cy.ts Outdated Show resolved Hide resolved
@appuk appuk merged commit 5befa26 into main Jun 4, 2024
17 checks passed
@appuk appuk deleted the add-roles-tab branch June 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishsanghishetty vishsanghishetty vishsanghishetty approved these changes

Assignees
No one assigned
Labels
E2E End-to-end testing EDA Label to indicate changes relevant to EDA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@appuk @vishsanghishetty